Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Revert "c9s: work around various SELinux issues" #1568

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Aug 14, 2024

This reverts commit 9ba8b71.

All the issues here should be fixed by selinux-policy-38.1.44-1.el9 according to the linked tickets. So we shouldn't need this anymore.

This reverts commit 9ba8b71.

All the issues here should be fixed by selinux-policy-38.1.44-1.el9
according to the linked tickets. So we shouldn't need this anymore.
@jlebon
Copy link
Member Author

jlebon commented Aug 14, 2024

Let's see what CI says. I think the only one not covered by CI will be the Afterburn one.
cc @aleskandro

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@jlebon
Copy link
Member Author

jlebon commented Aug 14, 2024

Quay.io flakes

/retest

@aleskandro
Copy link
Member

Quay is having issues in the past few hours

@jlebon
Copy link
Member Author

jlebon commented Aug 15, 2024

/retest

Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier travier changed the title Revert "c9s: work around various SELinux issues" NO-JIRA: Revert "c9s: work around various SELinux issues" Aug 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

This reverts commit 9ba8b71.

All the issues here should be fixed by selinux-policy-38.1.44-1.el9 according to the linked tickets. So we shouldn't need this anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier
Copy link
Member

travier commented Aug 22, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@travier
Copy link
Member

travier commented Aug 22, 2024

From #1556, https://issues.redhat.com/browse/RHEL-38614 is still in progress.

@jlebon
Copy link
Member Author

jlebon commented Oct 3, 2024

From #1556, issues.redhat.com/browse/RHEL-38614 is still in progress.

I think the status there is misleading. I think it's Release Pending because it's attached to a RHEL 9.5 errata, but it was indeed fixed in c9s (since the testiso tests pass here). So I think we can get this in?

/retest

@jbtrystram
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

7 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

6 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@jbtrystram
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

6 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@dustymabe
Copy link
Member

@jbtrystram - can you try to replicate the CI failures by doing a local build and running tests against SCOS? There are a lot of failures so I'd imagine we should be able to reproduce locally.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@jbtrystram
Copy link
Contributor

@jbtrystram - can you try to replicate the CI failures by doing a local build and running tests against SCOS? There are a lot of failures so I'd imagine we should be able to reproduce locally.

This is hitting https://issues.redhat.com/browse/RHEL-61612
Maybe fixed by #1631

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b753d25 and 2 for PR HEAD 093eefe in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3953cbb and 2 for PR HEAD 093eefe in total

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5371057 into openshift:master Oct 10, 2024
7 checks passed
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Oct 10, 2024
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants