-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Revert "c9s: work around various SELinux issues" #1568
NO-JIRA: Revert "c9s: work around various SELinux issues" #1568
Conversation
This reverts commit 9ba8b71. All the issues here should be fixed by selinux-policy-38.1.44-1.el9 according to the linked tickets. So we shouldn't need this anymore.
Let's see what CI says. I think the only one not covered by CI will be the Afterburn one. |
Quay.io flakes /retest |
Quay is having issues in the past few hours |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
From #1556, https://issues.redhat.com/browse/RHEL-38614 is still in progress. |
I think the status there is misleading. I think it's Release Pending because it's attached to a RHEL 9.5 errata, but it was indeed fixed in c9s (since the testiso tests pass here). So I think we can get this in? /retest |
/unhold |
7 similar comments
6 similar comments
/retest |
6 similar comments
@jbtrystram - can you try to replicate the CI failures by doing a local build and running tests against SCOS? There are a lot of failures so I'd imagine we should be able to reproduce locally. |
1 similar comment
This is hitting https://issues.redhat.com/browse/RHEL-61612 |
1 similar comment
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This reverts commit 9ba8b71.
All the issues here should be fixed by selinux-policy-38.1.44-1.el9 according to the linked tickets. So we shouldn't need this anymore.